Skip to content

/ next.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make eslint opt-in until it lands on stable #23509

Merged
merged 2 commits into from Mar 29, 2021
Merged

Make eslint opt-in until it lands on stable #23509

merged 2 commits into from Mar 29, 2021
+5 −1

Conversation

@timneutkens
Copy link
Member

@timneutkens timneutkens commented Mar 29, 2021 •
edited

Ensures that the current stable release does not get automatically opted into eslint support until it's been tried out on enough apps.

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes
@timneutkens
Make eslint opt-in until it lands on stable
Loading status checks…
d0c9fc5
@timneutkens timneutkens requested review from divmain, ijjk, lfades and shuding as code owners Mar 29, 2021
@ijjk ijjk added the type: next label Mar 29, 2021
@leerob
leerob reviewed Mar 29, 2021
View changes
@Timer
Timer reviewed Mar 29, 2021
View changes
@ijjk
ijjk reviewed Mar 29, 2021
View changes
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 29, 2021 •
edited

Failing test suites

Commit: d0c9fc5

test/integration/eslint/test/pkg-json-eslint-config.test.js

  • ESLint > should show warnings and errors based on eslint config in package.json
Expand output

● ESLint › should show warnings and errors based on eslint config in package.json

expect(received).toContain(expected) // indexOf

Expected substring: "./pages/index.js"
Received string:    "info  - Using webpack 4. Reason: future.webpack5 option not enabled https://nextjs.org/docs/messages/webpack5
warn  - No build cache found. Please configure build caching for faster rebuilds. Read more: https://nextjs.org/docs/messages/no-cache
info  - Checking validity of types...
info  - Creating an optimized production build...
info  - Compiled successfully
info  - Collecting page data...
info  - Generating static pages (0/3)
info  - Generating static pages (3/3)
info  - Finalizing page optimization...·
Page                                                           Size     First Load JS
┌ ○ /                                                          12.5 kB        77.7 kB
└ ○ /404                                                       2.79 kB          68 kB
+ First Load JS shared by all                                  65.2 kB
  ├ chunks/commons.e65b7d.js                                   5.32 kB
  ├ chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.5c0674.js  9.09 kB
  ├ chunks/framework.233949.js                                 42.2 kB
  ├ chunks/main.49b008.js                                      6.85 kB
  ├ chunks/pages/_app.6ab3f2.js                                1.01 kB
  └ chunks/webpack.50bee0.js                                   751 B·
λ  (Server)  server-side renders at runtime (uses getInitialProps or getServerSideProps)
○  (Static)  automatically rendered as static HTML (uses no initial props)
●  (SSG)     automatically generated as static HTML + JSON (uses getStaticProps)
   (ISR)     incremental static regeneration (uses revalidate in getStaticProps)·
"

  30 |       'No ESLint configuration was detected, but checks from the Next.js ESLint plugin were included automatically'
  31 |     )
> 32 |     expect(output).toContain('./pages/index.js')
     |                    ^
  33 |     expect(output).not.toContain(
  34 |       "8:9  Warning: A synchronous script tag can impact your webpage's performance  @next/next/no-sync-scripts"
  35 |     )

  at Object.<anonymous> (integration/eslint/test/pkg-json-eslint-config.test.js:32:20)

test/integration/eslint/test/custom-eslint-config.test.js

  • ESLint > should show warnings and errors based on custom eslint config
Expand output

● ESLint › should show warnings and errors based on custom eslint config

expect(received).toContain(expected) // indexOf

Expected substring: "./pages/index.js"
Received string:    "info  - Using webpack 4. Reason: future.webpack5 option not enabled https://nextjs.org/docs/messages/webpack5
warn  - No build cache found. Please configure build caching for faster rebuilds. Read more: https://nextjs.org/docs/messages/no-cache
info  - Checking validity of types...
info  - Creating an optimized production build...
info  - Using external babel configuration from /home/runner/work/next.js/next.js/test/.babelrc
info  - Compiled successfully
info  - Collecting page data...
info  - Generating static pages (0/3)
info  - Generating static pages (3/3)
info  - Finalizing page optimization...·
Page                                                           Size     First Load JS
┌ ○ /                                                          12.5 kB        77.7 kB
└ ○ /404                                                       2.79 kB          68 kB
+ First Load JS shared by all                                  65.2 kB
  ├ chunks/commons.e65b7d.js                                   5.32 kB
  ├ chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.5c0674.js  9.09 kB
  ├ chunks/framework.233949.js                                 42.2 kB
  ├ chunks/main.49b008.js                                      6.85 kB
  ├ chunks/pages/_app.6ab3f2.js                                1.01 kB
  └ chunks/webpack.50bee0.js                                   751 B·
λ  (Server)  server-side renders at runtime (uses getInitialProps or getServerSideProps)
○  (Static)  automatically rendered as static HTML (uses no initial props)
●  (SSG)     automatically generated as static HTML + JSON (uses getStaticProps)
   (ISR)     incremental static regeneration (uses revalidate in getStaticProps)·
"

  23 |       'No ESLint configuration was detected, but checks from the Next.js ESLint plugin were included automatically'
  24 |     )
> 25 |     expect(stdout).toContain('./pages/index.js')
     |                    ^
  26 |     expect(stdout).not.toContain(
  27 |       "8:9  Warning: A synchronous script tag can impact your webpage's performance  @next/next/no-sync-scripts"
  28 |     )

  at Object.<anonymous> (integration/eslint/test/custom-eslint-config.test.js:25:20)
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 29, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
buildDuration 12.9s 12s -907ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +2 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.048 2.064 ⚠️ +0.02
/ avg req/sec 1220.55 1211.05 ⚠️ -9.5
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.271 1.23 -0.04
/error-in-render avg req/sec 1967.28 2032.81 +65.53
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
buildDuration 14.9s 14.1s -771ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +2 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_error.js 1.36 MB 1.36 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.36 MB 1.36 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.41 MB 1.41 MB ✓
withRouter.js 1.41 MB 1.41 MB ✓
Overall change 6.99 MB 6.99 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
buildDuration 15.5s 14.5s -939ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +2 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.1 2.075 -0.02
/ avg req/sec 1190.54 1204.87 +14.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.301 1.215 -0.09
/error-in-render avg req/sec 1921.12 2057.94 +136.82
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
597-e27c5352..db8c.js gzip 13.3 kB 13.3 kB ✓
778-6ce6eb65..591b.js gzip 7.04 kB 7.04 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "0ChRw2xs1l6y4BzZPtdc0",
+        "buildId": "HPPJZITrO3b-oS25-lqFD",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0ChRw2xs1l6y4BzZPtdc0/_buildManifest.js"
+      src="/_next/static/HPPJZITrO3b-oS25-lqFD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0ChRw2xs1l6y4BzZPtdc0/_ssgManifest.js"
+      src="/_next/static/HPPJZITrO3b-oS25-lqFD/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "0ChRw2xs1l6y4BzZPtdc0",
+        "buildId": "HPPJZITrO3b-oS25-lqFD",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0ChRw2xs1l6y4BzZPtdc0/_buildManifest.js"
+      src="/_next/static/HPPJZITrO3b-oS25-lqFD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0ChRw2xs1l6y4BzZPtdc0/_ssgManifest.js"
+      src="/_next/static/HPPJZITrO3b-oS25-lqFD/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "0ChRw2xs1l6y4BzZPtdc0",
+        "buildId": "HPPJZITrO3b-oS25-lqFD",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0ChRw2xs1l6y4BzZPtdc0/_buildManifest.js"
+      src="/_next/static/HPPJZITrO3b-oS25-lqFD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0ChRw2xs1l6y4BzZPtdc0/_ssgManifest.js"
+      src="/_next/static/HPPJZITrO3b-oS25-lqFD/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: d0c9fc5
@timneutkens
Update tests
Loading status checks…
7944d68
@timneutkens timneutkens dismissed stale reviews from ijjk, Timer, and leerob via 7944d68 Mar 29, 2021
@leerob
leerob approved these changes Mar 29, 2021
View changes
@Timer
Timer approved these changes Mar 29, 2021
View changes
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 29, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
buildDuration 13.3s 12.7s -606ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.202 2.276 ⚠️ +0.07
/ avg req/sec 1135.34 1098.42 ⚠️ -36.92
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.519 1.629 ⚠️ +0.11
/error-in-render avg req/sec 1645.44 1535.07 ⚠️ -110.37
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
index.html gzip 613 B 613 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
buildDuration 14.2s 13.1s -1s
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +2 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
677f882d2ed8..7edd.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_app-8fbabfc..6440.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-c31053f..c329.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_buildManifest.js gzip 370 B 370 B ✓
Overall change 370 B 370 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_error.js 1.36 MB 1.36 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.36 MB 1.36 MB ✓
link.js 1.42 MB 1.42 MB ✓
routerDirect.js 1.41 MB 1.41 MB ✓
withRouter.js 1.41 MB 1.41 MB ✓
Overall change 6.99 MB 6.99 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
buildDuration 15s 14.3s -723ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +2 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.166 2.129 -0.04
/ avg req/sec 1154.17 1174.35 +20.18
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.376 1.569 ⚠️ +0.19
/error-in-render avg req/sec 1817.17 1593.36 ⚠️ -223.81
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
597-e27c5352..db8c.js gzip 13.3 kB 13.3 kB ✓
778-6ce6eb65..591b.js gzip 7.04 kB 7.04 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_app-5cc66b2..6f03.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-dd34d9b..0ade.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
_buildManifest.js gzip 349 B 349 B ✓
Overall change 349 B 349 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/eslint-opt-in Change
index.html gzip 609 B 609 B ✓
link.html gzip 614 B 614 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "RUgjAGHatWmXyGge6trOz",
+        "buildId": "omJ9LZyC1ci5WaI2mqZ9O",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/RUgjAGHatWmXyGge6trOz/_buildManifest.js"
+      src="/_next/static/omJ9LZyC1ci5WaI2mqZ9O/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/RUgjAGHatWmXyGge6trOz/_ssgManifest.js"
+      src="/_next/static/omJ9LZyC1ci5WaI2mqZ9O/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "RUgjAGHatWmXyGge6trOz",
+        "buildId": "omJ9LZyC1ci5WaI2mqZ9O",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/RUgjAGHatWmXyGge6trOz/_buildManifest.js"
+      src="/_next/static/omJ9LZyC1ci5WaI2mqZ9O/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/RUgjAGHatWmXyGge6trOz/_ssgManifest.js"
+      src="/_next/static/omJ9LZyC1ci5WaI2mqZ9O/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "RUgjAGHatWmXyGge6trOz",
+        "buildId": "omJ9LZyC1ci5WaI2mqZ9O",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/RUgjAGHatWmXyGge6trOz/_buildManifest.js"
+      src="/_next/static/omJ9LZyC1ci5WaI2mqZ9O/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/RUgjAGHatWmXyGge6trOz/_ssgManifest.js"
+      src="/_next/static/omJ9LZyC1ci5WaI2mqZ9O/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 7944d68
@timneutkens timneutkens merged commit 2ec2ea8 into vercel:canary Mar 29, 2021
24 of 30 checks passed
24 of 30 checks passed
build
Details
Cancel Previous Runs
Details
PR Stats
Details
testYarnPnP
Details
Webpack 5 (Basic, Production, Acceptance)
Details
React 16 + Webpack 4 (Basic, Production, Acceptance)
Details
lint
Details
Check Pre-compiled
Details
Test Unit
Details
Test Integration (1)
Details
Test Integration (2)
Details
Test Integration (3)
Details
Test Integration (4)
Details
Test Integration (5)
Details
Test Integration (6)
Details
Test Electron
Details
Test Firefox (production)
Details
Test Safari (production)
Details
Potentially publish release
Details
Test Safari 10.1 (nav)
Details
Release Stats
Details
azure next.js Build #20210329.7 had test failures
Details
azure next.js (Test test_chrome_integration node-10-1) Test test_chrome_integration node-10-1 failed
Details
azure next.js (Test test_chrome_integration node-10-2) Test test_chrome_integration node-10-2 failed
Details
azure next.js (Test test_chrome_integration node-10-3) Test test_chrome_integration node-10-3 failed
Details
azure next.js (Test test_chrome_integration node-10-4) Test test_chrome_integration node-10-4 failed
Details
azure next.js (Test test_ie11_production) Test test_ie11_production failed
Details
kodiakhq: status 🛑 cannot merge (missing required reviews)
Details
azure next.js (Build build) Build build succeeded
Details
azure next.js (Test test_unit) Test test_unit succeeded
Details
@timneutkens timneutkens deleted the timneutkens:add/eslint-opt-in branch Mar 29, 2021
Timer added a commit to Timer/next.js that referenced this pull request Mar 29, 2021
@Timer
Revert "Make eslint opt-in until it lands on stable (vercel#23509)"
Verified
This commit was signed with the committer’s verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
a346f0a 
This reverts commit 2ec2ea8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timer Timer

@leerob leerob

@ijjk ijjk

@divmain divmain

@lfades lfades

@shuding shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@timneutkens @ijjk @Timer @leerob