Update with-docker example and deployment docs.
#23486
Merged
+294
−72
Conversation
leerob
requested review from
divmain,
ijjk,
lfades,
shuding and
timneutkens
as
code owners
| @@ -124,7 +132,7 @@ EXPOSE 3000 | |||
| # Uncomment the following line in case you want to disable telemetry. | |||
| # RUN npx next telemetry disable | |||
| CMD ["node_modules/.bin/next", "start"] | |||
| CMD ["yarn", "start"] | |||
leerob
Mar 28, 2021
Author
Contributor
I changed this because Google Cloud Run requires you to forward a port to the start script. Then I realized it's probably confusing if package.json isn't the source of truth for how you're starting your application, so it's now looking there.
I changed this because Google Cloud Run requires you to forward a port to the start script. Then I realized it's probably confusing if package.json isn't the source of truth for how you're starting your application, so it's now looking there.
|
|
||
| You can view your images created with `docker images`. | ||
|
|
||
| ## Deploying to Google Cloud Run |
leerob
Mar 28, 2021
Author
Contributor
Confirmed this works 👍
Confirmed this works
kodiakhq
bot
merged commit d49f978
into
vercel:canary
23 checks passed
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Feature
fixes #numberDocumentation / Examples