Skip to content

/ next.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add os-browserify dep #23354

Merged
merged 5 commits into from Mar 29, 2021
Merged

Add os-browserify dep #23354

merged 5 commits into from Mar 29, 2021
+2 −1

Conversation

@timneutkens
Copy link
Member

@timneutkens timneutkens commented Mar 24, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes
@timneutkens
Add os-browserify dep
Loading status checks…
c96eb93
@timneutkens timneutkens requested review from divmain, ijjk, lfades and shuding as code owners Mar 24, 2021
@ijjk ijjk added the type: next label Mar 24, 2021
@sokra
sokra approved these changes Mar 24, 2021
View changes
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 24, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 15.5s 15.5s ✓
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.028 2.084 ⚠️ +0.06
/ avg req/sec 1233.03 1199.37 ⚠️ -33.66
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.419 1.465 ⚠️ +0.05
/error-in-render avg req/sec 1761.92 1706.55 ⚠️ -55.37
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 18.7s 18.8s ⚠️ +121ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.34 MB 1.34 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.39 MB 1.39 MB ✓
withRouter.js 1.39 MB 1.39 MB ⚠️ +4 B
Overall change 6.87 MB 6.87 MB ⚠️ +4 B
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 14.9s 15.5s ⚠️ +666ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.041 2.134 ⚠️ +0.09
/ avg req/sec 1224.76 1171.72 ⚠️ -53.04
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.49 1.488 0
/error-in-render avg req/sec 1678.09 1680.12 +2.03
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "Z3gO1i72A2fmv15yD9zDP",
+        "buildId": "93z_y87n-MSUr3mpqLL5x",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Z3gO1i72A2fmv15yD9zDP/_buildManifest.js"
+      src="/_next/static/93z_y87n-MSUr3mpqLL5x/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Z3gO1i72A2fmv15yD9zDP/_ssgManifest.js"
+      src="/_next/static/93z_y87n-MSUr3mpqLL5x/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "Z3gO1i72A2fmv15yD9zDP",
+        "buildId": "93z_y87n-MSUr3mpqLL5x",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Z3gO1i72A2fmv15yD9zDP/_buildManifest.js"
+      src="/_next/static/93z_y87n-MSUr3mpqLL5x/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Z3gO1i72A2fmv15yD9zDP/_ssgManifest.js"
+      src="/_next/static/93z_y87n-MSUr3mpqLL5x/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "Z3gO1i72A2fmv15yD9zDP",
+        "buildId": "93z_y87n-MSUr3mpqLL5x",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Z3gO1i72A2fmv15yD9zDP/_buildManifest.js"
+      src="/_next/static/93z_y87n-MSUr3mpqLL5x/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Z3gO1i72A2fmv15yD9zDP/_ssgManifest.js"
+      src="/_next/static/93z_y87n-MSUr3mpqLL5x/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: c96eb93
@sokra
Merge branch 'canary' into fix/os-browserify
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
71e5266
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 24, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 15.5s 15.4s -67ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.18 2.143 -0.04
/ avg req/sec 1146.61 1166.49 +19.88
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.428 1.414 -0.01
/error-in-render avg req/sec 1751.06 1768.22 +17.16
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 19.4s 19.7s ⚠️ +268ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.34 MB 1.34 MB ⚠️ +2 B
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.39 MB 1.39 MB ✓
withRouter.js 1.39 MB 1.39 MB ✓
Overall change 6.87 MB 6.87 MB ⚠️ +2 B
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 16.5s 17.1s ⚠️ +673ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.265 2.373 ⚠️ +0.11
/ avg req/sec 1103.9 1053.5 ⚠️ -50.4
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.667 1.621 -0.05
/error-in-render avg req/sec 1499.35 1542.33 +42.98
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "JWu3o0CfkuZApSs3WwmEr",
+        "buildId": "5D-Cd862BzEvBY1FWRYoQ",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/JWu3o0CfkuZApSs3WwmEr/_buildManifest.js"
+      src="/_next/static/5D-Cd862BzEvBY1FWRYoQ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/JWu3o0CfkuZApSs3WwmEr/_ssgManifest.js"
+      src="/_next/static/5D-Cd862BzEvBY1FWRYoQ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "JWu3o0CfkuZApSs3WwmEr",
+        "buildId": "5D-Cd862BzEvBY1FWRYoQ",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/JWu3o0CfkuZApSs3WwmEr/_buildManifest.js"
+      src="/_next/static/5D-Cd862BzEvBY1FWRYoQ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/JWu3o0CfkuZApSs3WwmEr/_ssgManifest.js"
+      src="/_next/static/5D-Cd862BzEvBY1FWRYoQ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "JWu3o0CfkuZApSs3WwmEr",
+        "buildId": "5D-Cd862BzEvBY1FWRYoQ",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/JWu3o0CfkuZApSs3WwmEr/_buildManifest.js"
+      src="/_next/static/5D-Cd862BzEvBY1FWRYoQ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/JWu3o0CfkuZApSs3WwmEr/_ssgManifest.js"
+      src="/_next/static/5D-Cd862BzEvBY1FWRYoQ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 71e5266
@Timer
Merge branch 'canary' into fix/os-browserify
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
29a56f7
@Timer
Timer approved these changes Mar 24, 2021
View changes
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 24, 2021

Failing test suites

Commit: 29a56f7

test/integration/amphtml/test/index.test.js

  • AMP Usage > AMP dev mode > should detect changes and refresh an AMP page
  • AMP Usage > AMP dev mode > should not reload unless the page is edited for an AMP page
Expand output

● AMP Usage › AMP dev mode › should detect changes and refresh an AMP page

expect(received).toBe(expected) // Object.is equality

Expected: "I'm an AMP page!"
Received: "replaced it!"

  361 |         browser = await webdriver(dynamicAppPort, '/hmr/amp')
  362 |         const text = await browser.elementByCss('p').text()
> 363 |         expect(text).toBe(`I'm an AMP page!`)
      |                      ^
  364 |
  365 |         const hmrTestPagePath = join(__dirname, '../', 'pages', 'hmr', 'amp.js')
  366 |

  at Object.<anonymous> (integration/amphtml/test/index.test.js:363:22)

● AMP Usage › AMP dev mode › should not reload unless the page is edited for an AMP page

TIMED OUT: /I'm an AMP page!/

replaced it!

  385 |
  386 |   if (hardError) {
> 387 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  388 |   }
  389 |   return false
  390 | }

  at check (lib/next-test-utils.js:387:11)
  at Object.<anonymous> (integration/amphtml/test/index.test.js:409:9)
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 24, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 16.3s 16.3s ⚠️ +39ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.209 2.253 ⚠️ +0.04
/ avg req/sec 1131.65 1109.74 ⚠️ -21.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.506 1.463 -0.04
/error-in-render avg req/sec 1659.7 1708.36 +48.66
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 20s 20s -64ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.34 MB 1.34 MB ✓
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.39 MB 1.39 MB ✓
withRouter.js 1.39 MB 1.39 MB ✓
Overall change 6.87 MB 6.87 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 16.2s 16.3s ⚠️ +12ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.185 2.222 ⚠️ +0.04
/ avg req/sec 1144.24 1124.94 ⚠️ -19.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.499 1.489 -0.01
/error-in-render avg req/sec 1668.26 1679.17 +10.91
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-b5b29537..169f.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "YFoyL5O1vT8JyvY_p5Pqe",
+        "buildId": "1025N8gtAl4G2sOizU7lY",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/YFoyL5O1vT8JyvY_p5Pqe/_buildManifest.js"
+      src="/_next/static/1025N8gtAl4G2sOizU7lY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/YFoyL5O1vT8JyvY_p5Pqe/_ssgManifest.js"
+      src="/_next/static/1025N8gtAl4G2sOizU7lY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "YFoyL5O1vT8JyvY_p5Pqe",
+        "buildId": "1025N8gtAl4G2sOizU7lY",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/YFoyL5O1vT8JyvY_p5Pqe/_buildManifest.js"
+      src="/_next/static/1025N8gtAl4G2sOizU7lY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/YFoyL5O1vT8JyvY_p5Pqe/_ssgManifest.js"
+      src="/_next/static/1025N8gtAl4G2sOizU7lY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "YFoyL5O1vT8JyvY_p5Pqe",
+        "buildId": "1025N8gtAl4G2sOizU7lY",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/YFoyL5O1vT8JyvY_p5Pqe/_buildManifest.js"
+      src="/_next/static/1025N8gtAl4G2sOizU7lY/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/YFoyL5O1vT8JyvY_p5Pqe/_ssgManifest.js"
+      src="/_next/static/1025N8gtAl4G2sOizU7lY/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 29a56f7
@ijjk
Merge branch 'canary' into fix/os-browserify
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e36689f
@ijjk
ijjk approved these changes Mar 24, 2021
View changes
@kodiakhq
Merge branch 'canary' into fix/os-browserify
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9f342fa
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 24, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 15.3s 15.3s ⚠️ +22ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.052 2.019 -0.03
/ avg req/sec 1218.16 1238.37 +20.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.226 1.265 ⚠️ +0.04
/error-in-render avg req/sec 2038.97 1976.2 ⚠️ -62.77
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-95c4fcdf..36e9.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 18.7s 18s -701ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-95c4fcdf..36e9.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_error.js 1.34 MB 1.34 MB ✓
404.html 2.76 kB 2.76 kB ✓
500.html 2.75 kB 2.75 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.96 kB 1.96 kB ✓
hooks.html 2.01 kB 2.01 kB ✓
index.js 1.34 MB 1.34 MB -2 B
link.js 1.4 MB 1.4 MB ✓
routerDirect.js 1.39 MB 1.39 MB ✓
withRouter.js 1.39 MB 1.39 MB ✓
Overall change 6.89 MB 6.89 MB -2 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
buildDuration 15.3s 14.9s -376ms
nodeModulesSize 61.7 MB 61.7 MB ⚠️ +170 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.054 1.983 -0.07
/ avg req/sec 1217.27 1260.73 +43.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.268 1.253 -0.02
/error-in-render avg req/sec 1971.63 1995.13 +23.5
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
597-ec2335c0..e105.js gzip 13.3 kB 13.3 kB ✓
778-95c4fcdf..36e9.js gzip 7.06 kB 7.06 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 151 B 151 B ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.8 kB 60.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_app-bdbd9e6..6cfe.js gzip 1.3 kB 1.3 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-d124373..c521.js gzip 1.66 kB 1.66 kB ✓
routerDirect..5759.js gzip 336 B 336 B ✓
withRouter-1..98bf.js gzip 334 B 334 B ✓
Overall change 8.76 kB 8.76 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/os-browserify Change
index.html gzip 609 B 609 B ✓
link.html gzip 615 B 615 B ✓
withRouter.html gzip 604 B 604 B ✓
Overall change 1.83 kB 1.83 kB ✓

Diffs

Diff for index.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "Xkn8SXjdmn95HhsT1BFtz",
+        "buildId": "yqRjzqpaqNS32QNWX5_Uz",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Xkn8SXjdmn95HhsT1BFtz/_buildManifest.js"
+      src="/_next/static/yqRjzqpaqNS32QNWX5_Uz/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Xkn8SXjdmn95HhsT1BFtz/_ssgManifest.js"
+      src="/_next/static/yqRjzqpaqNS32QNWX5_Uz/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -53,7 +53,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "Xkn8SXjdmn95HhsT1BFtz",
+        "buildId": "yqRjzqpaqNS32QNWX5_Uz",
         "isFallback": false,
         "gip": true
       }
@@ -91,11 +91,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Xkn8SXjdmn95HhsT1BFtz/_buildManifest.js"
+      src="/_next/static/yqRjzqpaqNS32QNWX5_Uz/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Xkn8SXjdmn95HhsT1BFtz/_ssgManifest.js"
+      src="/_next/static/yqRjzqpaqNS32QNWX5_Uz/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "Xkn8SXjdmn95HhsT1BFtz",
+        "buildId": "yqRjzqpaqNS32QNWX5_Uz",
         "isFallback": false,
         "gip": true
       }
@@ -86,11 +86,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Xkn8SXjdmn95HhsT1BFtz/_buildManifest.js"
+      src="/_next/static/yqRjzqpaqNS32QNWX5_Uz/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Xkn8SXjdmn95HhsT1BFtz/_ssgManifest.js"
+      src="/_next/static/yqRjzqpaqNS32QNWX5_Uz/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 9f342fa
@merceyz merceyz mentioned this pull request Mar 24, 2021
Merged
2 of 8 tasks complete
@strothj strothj mentioned this pull request Mar 25, 2021
Open
1 of 8 tasks complete
@timneutkens timneutkens merged commit cd9bb98 into vercel:canary Mar 29, 2021
25 of 31 checks passed
25 of 31 checks passed
build
Details
Cancel Previous Runs
Details
PR Stats
Details
testYarnPnP testYarnPnP
Details
Webpack 5 (Basic, Production, Acceptance)
Details
React 16 + Webpack 4 (Basic, Production, Acceptance)
Details
lint
Details
Check Pre-compiled
Details
Test Unit
Details
Test Integration (1)
Details
Test Integration (2)
Details
Test Integration (3)
Details
Test Integration (4)
Details
Test Integration (5)
Details
Test Integration (6)
Details
Test Electron
Details
Test Firefox (production)
Details
Test Safari (production)
Details
Potentially publish release
Details
thank you, next
Details
Test Safari 10.1 (nav)
Details
Release Stats
Details
azure next.js Build #20210324.29 had test failures
Details
azure next.js (Test test_chrome_integration node-10-1) Test test_chrome_integration node-10-1 failed
Details
azure next.js (Test test_chrome_integration node-10-2) Test test_chrome_integration node-10-2 failed
Details
azure next.js (Test test_chrome_integration node-10-3) Test test_chrome_integration node-10-3 failed
Details
azure next.js (Test test_chrome_integration node-10-4) Test test_chrome_integration node-10-4 failed
Details
kodiakhq: status 🛑 cannot merge (failing required status checks: {'React 16 + Webpack 4 (Basic, Production, Acceptance)'})
Details
azure next.js (Build build) Build build succeeded
Details
azure next.js (Test test_ie11_production) Test test_ie11_production succeeded
Details
azure next.js (Test test_unit) Test test_unit succeeded
Details
@timneutkens timneutkens deleted the timneutkens:fix/os-browserify branch Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timer Timer

@sokra sokra

@ijjk ijjk

@divmain divmain

@lfades lfades

@shuding shuding

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@timneutkens @ijjk @Timer @sokra