Skip to content

/ next.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent use of colons in contributing docs #23260

Merged
merged 3 commits into from Mar 22, 2021
Merged

Consistent use of colons in contributing docs #23260

merged 3 commits into from Mar 22, 2021
+1 −1

Conversation

@elitan
Copy link
Contributor

@elitan elitan commented Mar 22, 2021 •
edited

Consistent use of colons in contribute.md.
@elitan
Consistent use of colon
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3f38283
@elitan elitan changed the title Consistent use of colon Consistent use of colons Mar 22, 2021
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 22, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary elitan/next.js patch-1 Change
buildDuration 12.3s 11.7s -569ms
nodeModulesSize 43.6 MB 43.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary elitan/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.999 2.052 ⚠️ +0.05
/ avg req/sec 1250.89 1218.45 ⚠️ -32.44
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.275 1.293 ⚠️ +0.02
/error-in-render avg req/sec 1960.36 1932.99 ⚠️ -27.37
Client Bundles (main, webpack, commons)
vercel/next.js canary elitan/next.js patch-1 Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary elitan/next.js patch-1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary elitan/next.js patch-1 Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary elitan/next.js patch-1 Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary elitan/next.js patch-1 Change
index.html gzip 613 B 613 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary elitan/next.js patch-1 Change
buildDuration 14.1s 14s -86ms
nodeModulesSize 43.6 MB 43.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary elitan/next.js patch-1 Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary elitan/next.js patch-1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary elitan/next.js patch-1 Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary elitan/next.js patch-1 Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary elitan/next.js patch-1 Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary elitan/next.js patch-1 Change
buildDuration 13.8s 13.8s ⚠️ +52ms
nodeModulesSize 43.6 MB 43.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary elitan/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.01 2.029 ⚠️ +0.02
/ avg req/sec 1243.8 1232.29 ⚠️ -11.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.242 1.272 ⚠️ +0.03
/error-in-render avg req/sec 2013.38 1964.67 ⚠️ -48.71
Client Bundles (main, webpack, commons)
vercel/next.js canary elitan/next.js patch-1 Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.1 kB 7.1 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary elitan/next.js patch-1 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary elitan/next.js patch-1 Change
_app-d0eb668..79ef.js gzip 1.28 kB 1.28 kB ✓
_error-d12ff..6063.js gzip 3.4 kB 3.4 kB ✓
amp-127483e4..9cd8.js gzip 560 B 560 B ✓
hooks-75994b..62d3.js gzip 924 B 924 B ✓
index-ac1ee6..819e.js gzip 243 B 243 B ✓
link-1cd4709..71e5.js gzip 1.65 kB 1.65 kB ✓
routerDirect..4d90.js gzip 333 B 333 B ✓
withRouter-0..60b0.js gzip 329 B 329 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary elitan/next.js patch-1 Change
_buildManifest.js gzip 324 B 324 B ✓
Overall change 324 B 324 B ✓
Rendered Page Sizes
vercel/next.js canary elitan/next.js patch-1 Change
index.html gzip 586 B 586 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "GoPEYWOSAbp7YRwzuCNz0",
+        "buildId": "i22w7Ogfg5s3kTr55Ig1y",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/GoPEYWOSAbp7YRwzuCNz0/_buildManifest.js"
+      src="/_next/static/i22w7Ogfg5s3kTr55Ig1y/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/GoPEYWOSAbp7YRwzuCNz0/_ssgManifest.js"
+      src="/_next/static/i22w7Ogfg5s3kTr55Ig1y/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "GoPEYWOSAbp7YRwzuCNz0",
+        "buildId": "i22w7Ogfg5s3kTr55Ig1y",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/GoPEYWOSAbp7YRwzuCNz0/_buildManifest.js"
+      src="/_next/static/i22w7Ogfg5s3kTr55Ig1y/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/GoPEYWOSAbp7YRwzuCNz0/_ssgManifest.js"
+      src="/_next/static/i22w7Ogfg5s3kTr55Ig1y/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "GoPEYWOSAbp7YRwzuCNz0",
+        "buildId": "i22w7Ogfg5s3kTr55Ig1y",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/GoPEYWOSAbp7YRwzuCNz0/_buildManifest.js"
+      src="/_next/static/i22w7Ogfg5s3kTr55Ig1y/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/GoPEYWOSAbp7YRwzuCNz0/_ssgManifest.js"
+      src="/_next/static/i22w7Ogfg5s3kTr55Ig1y/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 3f38283
@timneutkens
timneutkens approved these changes Mar 22, 2021
View changes
@kodiakhq
Merge branch 'canary' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ec47ca0
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 22, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary elitan/next.js patch-1 Change
buildDuration 13.3s 12.8s -593ms
nodeModulesSize 43.6 MB 43.6 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary elitan/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.353 2.367 ⚠️ +0.01
/ avg req/sec 1062.64 1056.39 ⚠️ -6.25
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.653 1.619 -0.03
/error-in-render avg req/sec 1512.84 1544.6 +31.76
Client Bundles (main, webpack, commons)
vercel/next.js canary elitan/next.js patch-1 Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary elitan/next.js patch-1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary elitan/next.js patch-1 Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary elitan/next.js patch-1 Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary elitan/next.js patch-1 Change
index.html gzip 613 B 613 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary elitan/next.js patch-1 Change
buildDuration 14.8s 15.6s ⚠️ +825ms
nodeModulesSize 43.6 MB 43.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary elitan/next.js patch-1 Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary elitan/next.js patch-1 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary elitan/next.js patch-1 Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary elitan/next.js patch-1 Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary elitan/next.js patch-1 Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary elitan/next.js patch-1 Change
buildDuration 15.3s 15.2s -31ms
nodeModulesSize 43.6 MB 43.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary elitan/next.js patch-1 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.309 2.335 ⚠️ +0.03
/ avg req/sec 1082.65 1070.81 ⚠️ -11.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.546 1.57 ⚠️ +0.02
/error-in-render avg req/sec 1616.77 1592.43 ⚠️ -24.34
Client Bundles (main, webpack, commons)
vercel/next.js canary elitan/next.js patch-1 Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary elitan/next.js patch-1 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary elitan/next.js patch-1 Change
_app-b5edc60..e5c2.js gzip 1.29 kB 1.29 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-3631090..4cab.js gzip 1.65 kB 1.65 kB ✓
routerDirect..20d7.js gzip 328 B 328 B ✓
withRouter-b..a4b9.js gzip 326 B 326 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary elitan/next.js patch-1 Change
_buildManifest.js gzip 325 B 325 B ✓
Overall change 325 B 325 B ✓
Rendered Page Sizes
vercel/next.js canary elitan/next.js patch-1 Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "rhXCe_XavPpQeS7AvFkFA",
+        "buildId": "GTq_vyETOdtTSQYtn8sRe",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/rhXCe_XavPpQeS7AvFkFA/_buildManifest.js"
+      src="/_next/static/GTq_vyETOdtTSQYtn8sRe/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/rhXCe_XavPpQeS7AvFkFA/_ssgManifest.js"
+      src="/_next/static/GTq_vyETOdtTSQYtn8sRe/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "rhXCe_XavPpQeS7AvFkFA",
+        "buildId": "GTq_vyETOdtTSQYtn8sRe",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/rhXCe_XavPpQeS7AvFkFA/_buildManifest.js"
+      src="/_next/static/GTq_vyETOdtTSQYtn8sRe/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/rhXCe_XavPpQeS7AvFkFA/_ssgManifest.js"
+      src="/_next/static/GTq_vyETOdtTSQYtn8sRe/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "rhXCe_XavPpQeS7AvFkFA",
+        "buildId": "GTq_vyETOdtTSQYtn8sRe",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/rhXCe_XavPpQeS7AvFkFA/_buildManifest.js"
+      src="/_next/static/GTq_vyETOdtTSQYtn8sRe/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/rhXCe_XavPpQeS7AvFkFA/_ssgManifest.js"
+      src="/_next/static/GTq_vyETOdtTSQYtn8sRe/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: ec47ca0
@leerob
leerob approved these changes Mar 22, 2021
View changes
Copy link
Contributor

@leerob leerob left a comment

Thank you!
@kodiakhq
Merge branch 'canary' into patch-1
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
618251f
@leerob leerob changed the title Consistent use of colons Consistent use of colons in contributing docs Mar 22, 2021
@timneutkens timneutkens merged commit f384cd1 into vercel:canary Mar 22, 2021
8 of 10 checks passed
8 of 10 checks passed
build
Details
Cancel Previous Runs
Details
Cancel Previous Runs
Details
PR Stats
Details
testYarnPnP
Details
Webpack 5 (Basic, Production, Acceptance)
Details
React 16 + Webpack 4 (Basic, Production, Acceptance)
Details
azure next.js Build #20210322.6 failed
Details
azure next.js (Build build) Build build failed
Details
kodiakhq: status ⛴ merging PR (waiting for status checks: {'Test Integration (5)', 'Test Firefox (production)', 'lint', 'Test Integration (3)', 'Test Integration (6)', 'Test Unit', 'Test Integration (2)', 'Check Pre-compiled', 'Test Integration (4)', 'Test Integration (1)', 'Webpack 5 (Basic, Production, Acceptance)', 'React 16 + Webpack 4 (Basic, Production, Acceptance)', 'build', 'PR Stats'})
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timneutkens timneutkens

@leerob leerob

@divmain divmain

@ijjk ijjk

@lfades lfades

@shuding shuding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@elitan @ijjk @timneutkens @leerob