Skip to content

/ next.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESLint to Next.js #22437

Merged
merged 51 commits into from Mar 23, 2021
Merged

Add ESLint to Next.js #22437

merged 51 commits into from Mar 23, 2021
+900 −25

Conversation

@housseindjirdeh
Copy link
Collaborator

@housseindjirdeh housseindjirdeh commented Feb 22, 2021 •
edited

For #22228

This PR:

  • Adds ESLint to toolchain
    • Included by default for builds (next build)
    • Can be enabled for development (next dev)
    • Custom formatter built for output
  • Adds appropriate tests
  • Adds two documentation pages
@leerob
leerob reviewed Feb 23, 2021
View changes
docs/api-reference/next.config.js/eslint-warnings-errors.md Outdated Show resolved Hide resolved
docs/api-reference/next.config.js/eslint-warnings-errors.md Outdated Show resolved Hide resolved
docs/basic-features/eslint.md Outdated Show resolved Hide resolved
docs/basic-features/eslint.md Outdated Show resolved Hide resolved
docs/basic-features/eslint.md Outdated Show resolved Hide resolved
docs/basic-features/eslint.md Outdated

> If you add an `.eslintrc` file to your application and not include `plugin:@next/next/recommended`
> to the config, its rules will not be checked during development or production builds. This is
> **not recommended**.

This comment has been minimized.

Sign in to view
@leerob

leerob Feb 23, 2021
Contributor

Should it throw an error if they do this?

This comment has been minimized.

Sign in to view
@housseindjirdeh

housseindjirdeh Feb 23, 2021
Author Collaborator

A warning is displayed if they decide not to include the plugin. It may be too strict to throw an error and not let users easily opt-out of not including it.

I'll be working on better surfacing of warnings/errors next so I'll evaluate different options to inform the user if they don't include the plugin themselves (error overlay, etc...) :)
@leerob
Copy link
Contributor

@leerob leerob commented Feb 23, 2021

Great job with this! 👏
@housseindjirdeh housseindjirdeh force-pushed the azukaru:new-lint branch from d6b63f1 to 709a9a4 Feb 23, 2021
@ijjk

This comment has been hidden.

Sign in to view
@ijjk

This comment has been hidden.

Sign in to view
@ijjk

This comment has been hidden.

Sign in to view
@ijjk

This comment has been hidden.

Sign in to view
@ijjk

This comment has been hidden.

Sign in to view
@housseindjirdeh housseindjirdeh force-pushed the azukaru:new-lint branch from bce4aa3 to 21b04fa Feb 23, 2021
@ijjk

This comment has been hidden.

Sign in to view
@ijjk

This comment has been hidden.

Sign in to view
@housseindjirdeh housseindjirdeh force-pushed the azukaru:new-lint branch from 0ed3cbb to 7375fd3 Feb 24, 2021
@ijjk

This comment has been hidden.

Sign in to view
@ijjk

This comment has been hidden.

Sign in to view
@housseindjirdeh housseindjirdeh force-pushed the azukaru:new-lint branch from 76d4bf2 to 5f83adb Feb 25, 2021
@ijjk

This comment has been hidden.

Sign in to view
@ijjk

This comment has been hidden.

Sign in to view
@housseindjirdeh housseindjirdeh force-pushed the azukaru:new-lint branch from 5f83adb to 43919f0 Feb 26, 2021
@ijjk

This comment has been hidden.

Sign in to view
@ijjk

This comment has been hidden.

Sign in to view
@housseindjirdeh housseindjirdeh force-pushed the azukaru:new-lint branch from 622712e to 4dfbb41 Mar 18, 2021
@housseindjirdeh
Merge branch 'canary' into new-lint
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5fa6c39
@housseindjirdeh
fix formatting
Loading status checks…
a22033c
@ijjk ijjk added the type: example label Mar 18, 2021
@ijjk

This comment has been hidden.

Sign in to view
@housseindjirdeh
updates bash script
Loading status checks…
2b305f4
@housseindjirdeh
Merge branch 'canary' into new-lint
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
693b685
@ijjk

This comment has been hidden.

Sign in to view
@ijjk
ijjk reviewed Mar 22, 2021
View changes
packages/eslint-plugin-next/lib/rules/no-html-link-for-pages.js Outdated
@@ -23,6 +23,7 @@ module.exports = {
: [
path.join(context.getCwd(), 'pages'),
path.join(context.getCwd(), 'src', 'pages'),
path.join(context.getCwd(), 'build', 'pages'),

This comment has been minimized.

Sign in to view
@ijjk

ijjk Mar 22, 2021
Member

Suggested change
path.join(context.getCwd(), 'build', 'pages'),

The only two valid pages directories currently are pages and src/pages, was build/pages meant to be added here?

This comment has been minimized.

Sign in to view
@housseindjirdeh

housseindjirdeh Mar 22, 2021
Author Collaborator

Removed. Included it because I wanted to investigate why a test was failing but forgot to remove 😅
@ijjk
ijjk reviewed Mar 22, 2021
View changes
packages/next/build/index.ts Outdated
if (config.eslint?.build) {
await nextBuildSpan
.traceChild('verify-eslint-setup')
.traceAsyncFn(() => verifyEslintSetup(dir, pagesDir, null))

This comment has been minimized.

Sign in to view
@ijjk

ijjk Mar 22, 2021
Member

Do we want to block the build while this is running? We could move this to a separate worker to allow the build to continue and then exit with an error if linting fails

This comment has been minimized.

Sign in to view
@housseindjirdeh

housseindjirdeh Mar 22, 2021
Author Collaborator

Good call. Updated to use a new worker so it doesn't block build 👍
@ijjk
ijjk reviewed Mar 22, 2021
View changes
packages/next/lib/verifyEslintSetup.ts Outdated
plugins: string[]
}

export async function verifyEslintSetup(

This comment has been minimized.

Sign in to view
@ijjk

ijjk Mar 22, 2021
Member

Should we rename this to something like verifyAndLint to make it more clear it is doing actual linting here and not just verifying the config?

This comment has been minimized.

Sign in to view
@housseindjirdeh

housseindjirdeh Mar 22, 2021
Author Collaborator

Updated :)
@ijjk
ijjk reviewed Mar 22, 2021
View changes
packages/next/server/on-demand-entry-handler.ts Outdated
@@ -192,6 +195,9 @@ export default function onDemandEntryHandler(
}
}

// TODO: Move out of hot-reloader into a separate process
if (eslint) verifyEslintSetup(process.cwd(), pagesDir, pagePath)

This comment has been minimized.

Sign in to view
@ijjk

ijjk Mar 22, 2021
Member

Are we wanting to update this in a follow-up PR since we're starting with dev linting disabled by default?

This comment has been minimized.

Sign in to view
@housseindjirdeh

housseindjirdeh Mar 22, 2021
Author Collaborator

Yep exactly. Will enable it by default in a future PR when it doesn't affect page compilation time + fast refresh
@housseindjirdeh
moves linting to worker thread during build
26eb90e
@housseindjirdeh
removes unecessary build src addition to lint plugin rule
Loading status checks…
e45282d
@housseindjirdeh housseindjirdeh requested a review from shuding as a code owner Mar 22, 2021
@housseindjirdeh
Merge branch 'canary' into new-lint
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
12f9275
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 23, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 14.1s 15.2s ⚠️ +1.2s
nodeModulesSize 43.6 MB 59.4 MB ⚠️ +15.8 MB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js new-lint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.6 2.504 -0.1
/ avg req/sec 961.56 998.48 +36.92
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.712 1.72 ⚠️ +0.01
/error-in-render avg req/sec 1460.01 1453.12 ⚠️ -6.89
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js new-lint Change
index.html gzip 612 B 612 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 16.3s 17.5s ⚠️ +1.2s
nodeModulesSize 43.6 MB 59.4 MB ⚠️ +15.8 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary azukaru/next.js new-lint Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 16.8s 18.5s ⚠️ +1.8s
nodeModulesSize 43.6 MB 59.4 MB ⚠️ +15.8 MB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js new-lint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.539 2.467 -0.07
/ avg req/sec 984.7 1013.21 +28.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.851 1.719 -0.13
/error-in-render avg req/sec 1350.88 1454.26 +103.38
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-b5edc60..e5c2.js gzip 1.29 kB 1.29 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-3631090..4cab.js gzip 1.65 kB 1.65 kB ✓
routerDirect..20d7.js gzip 328 B 328 B ✓
withRouter-b..a4b9.js gzip 326 B 326 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 325 B 325 B ✓
Overall change 325 B 325 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js new-lint Change
index.html gzip 585 B 585 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "TgApYMxm5DwYI87iB2eFT",
+        "buildId": "DFcTqotlgwlxP1BBze1jA",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/TgApYMxm5DwYI87iB2eFT/_buildManifest.js"
+      src="/_next/static/DFcTqotlgwlxP1BBze1jA/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/TgApYMxm5DwYI87iB2eFT/_ssgManifest.js"
+      src="/_next/static/DFcTqotlgwlxP1BBze1jA/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "TgApYMxm5DwYI87iB2eFT",
+        "buildId": "DFcTqotlgwlxP1BBze1jA",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/TgApYMxm5DwYI87iB2eFT/_buildManifest.js"
+      src="/_next/static/DFcTqotlgwlxP1BBze1jA/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/TgApYMxm5DwYI87iB2eFT/_ssgManifest.js"
+      src="/_next/static/DFcTqotlgwlxP1BBze1jA/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "TgApYMxm5DwYI87iB2eFT",
+        "buildId": "DFcTqotlgwlxP1BBze1jA",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/TgApYMxm5DwYI87iB2eFT/_buildManifest.js"
+      src="/_next/static/DFcTqotlgwlxP1BBze1jA/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/TgApYMxm5DwYI87iB2eFT/_ssgManifest.js"
+      src="/_next/static/DFcTqotlgwlxP1BBze1jA/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 12f9275
@housseindjirdeh
adds empty log to fix formatting
Loading status checks…
10e0fac
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 23, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 11.3s 12.6s ⚠️ +1.3s
nodeModulesSize 43.6 MB 59.4 MB ⚠️ +15.8 MB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js new-lint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.961 1.929 -0.03
/ avg req/sec 1275.03 1296.03 +21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.184 1.167 -0.02
/error-in-render avg req/sec 2111.5 2142.16 +30.66
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js new-lint Change
index.html gzip 612 B 612 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 13.5s 14s ⚠️ +545ms
nodeModulesSize 43.6 MB 59.4 MB ⚠️ +15.8 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary azukaru/next.js new-lint Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 13.4s 14.5s ⚠️ +1.2s
nodeModulesSize 43.6 MB 59.4 MB ⚠️ +15.8 MB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js new-lint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.995 1.938 -0.06
/ avg req/sec 1253.19 1290.16 +36.97
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.247 1.211 -0.04
/error-in-render avg req/sec 2004.16 2064.99 +60.83
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-b5edc60..e5c2.js gzip 1.29 kB 1.29 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-3631090..4cab.js gzip 1.65 kB 1.65 kB ✓
routerDirect..20d7.js gzip 328 B 328 B ✓
withRouter-b..a4b9.js gzip 326 B 326 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 325 B 325 B ✓
Overall change 325 B 325 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js new-lint Change
index.html gzip 585 B 585 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "J_4aQVc4eBUfBfeifECOT",
+        "buildId": "KO79FO8lWmSheW7g5pPJn",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/J_4aQVc4eBUfBfeifECOT/_buildManifest.js"
+      src="/_next/static/KO79FO8lWmSheW7g5pPJn/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/J_4aQVc4eBUfBfeifECOT/_ssgManifest.js"
+      src="/_next/static/KO79FO8lWmSheW7g5pPJn/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "J_4aQVc4eBUfBfeifECOT",
+        "buildId": "KO79FO8lWmSheW7g5pPJn",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/J_4aQVc4eBUfBfeifECOT/_buildManifest.js"
+      src="/_next/static/KO79FO8lWmSheW7g5pPJn/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/J_4aQVc4eBUfBfeifECOT/_ssgManifest.js"
+      src="/_next/static/KO79FO8lWmSheW7g5pPJn/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "J_4aQVc4eBUfBfeifECOT",
+        "buildId": "KO79FO8lWmSheW7g5pPJn",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/J_4aQVc4eBUfBfeifECOT/_buildManifest.js"
+      src="/_next/static/KO79FO8lWmSheW7g5pPJn/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/J_4aQVc4eBUfBfeifECOT/_ssgManifest.js"
+      src="/_next/static/KO79FO8lWmSheW7g5pPJn/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 10e0fac
@housseindjirdeh
pass pagesDir and prevent fatal error when dir not found
Loading status checks…
2e6e043
@housseindjirdeh
Merge branch 'canary' into new-lint
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
42b5e52
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 23, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 13.9s 15.2s ⚠️ +1.3s
nodeModulesSize 43.6 MB 59.4 MB ⚠️ +15.8 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.503 2.58 ⚠️ +0.08
/ avg req/sec 998.72 968.94 ⚠️ -29.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.791 1.777 -0.01
/error-in-render avg req/sec 1395.66 1406.61 +10.95
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js new-lint Change
index.html gzip 612 B 612 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 16.1s 17s ⚠️ +858ms
nodeModulesSize 43.6 MB 59.4 MB ⚠️ +15.8 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary azukaru/next.js new-lint Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 16.3s 18.3s ⚠️ +2s
nodeModulesSize 43.6 MB 59.4 MB ⚠️ +15.8 MB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js new-lint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.601 2.515 -0.09
/ avg req/sec 961.22 993.84 +32.62
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.769 1.769 ✓
/error-in-render avg req/sec 1413.45 1413.31 ⚠️ -0.14
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-b5edc60..e5c2.js gzip 1.29 kB 1.29 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-3631090..4cab.js gzip 1.65 kB 1.65 kB ✓
routerDirect..20d7.js gzip 328 B 328 B ✓
withRouter-b..a4b9.js gzip 326 B 326 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 325 B 325 B ✓
Overall change 325 B 325 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js new-lint Change
index.html gzip 585 B 585 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "ZRY_DnJQGtgfFAA8KPCtf",
+        "buildId": "rjjtxoduwQWEsxfSeBdi7",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ZRY_DnJQGtgfFAA8KPCtf/_buildManifest.js"
+      src="/_next/static/rjjtxoduwQWEsxfSeBdi7/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ZRY_DnJQGtgfFAA8KPCtf/_ssgManifest.js"
+      src="/_next/static/rjjtxoduwQWEsxfSeBdi7/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "ZRY_DnJQGtgfFAA8KPCtf",
+        "buildId": "rjjtxoduwQWEsxfSeBdi7",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ZRY_DnJQGtgfFAA8KPCtf/_buildManifest.js"
+      src="/_next/static/rjjtxoduwQWEsxfSeBdi7/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ZRY_DnJQGtgfFAA8KPCtf/_ssgManifest.js"
+      src="/_next/static/rjjtxoduwQWEsxfSeBdi7/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "ZRY_DnJQGtgfFAA8KPCtf",
+        "buildId": "rjjtxoduwQWEsxfSeBdi7",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ZRY_DnJQGtgfFAA8KPCtf/_buildManifest.js"
+      src="/_next/static/rjjtxoduwQWEsxfSeBdi7/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ZRY_DnJQGtgfFAA8KPCtf/_ssgManifest.js"
+      src="/_next/static/rjjtxoduwQWEsxfSeBdi7/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 42b5e52
@housseindjirdeh
adds check to pkgjson eslint config for next plugin
Loading status checks…
9522110
@housseindjirdeh
Merge branch 'canary' into new-lint
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4be0299
@ijjk
Copy link
Member

@ijjk ijjk commented Mar 23, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 12s 12.8s ⚠️ +784ms
nodeModulesSize 45.5 MB 61.3 MB ⚠️ +15.8 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.026 2.035 ⚠️ +0.01
/ avg req/sec 1234.17 1228.64 ⚠️ -5.53
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.238 1.279 ⚠️ +0.04
/error-in-render avg req/sec 2019.91 1954.46 ⚠️ -65.45
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js new-lint Change
index.html gzip 612 B 612 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 13.9s 14.8s ⚠️ +848ms
nodeModulesSize 45.5 MB 61.3 MB ⚠️ +15.8 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 7.14 kB 7.14 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 60.3 kB 60.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-fde3324..9dd1.js gzip 1.28 kB 1.28 kB ✓
_error-af59f..582f.js gzip 3.46 kB 3.46 kB ✓
amp-9716187d..0aa8.js gzip 536 B 536 B ✓
hooks-107e90..74c7.js gzip 888 B 888 B ✓
index-ac435c..ecf2.js gzip 227 B 227 B ✓
link-e6cee42..49eb.js gzip 1.64 kB 1.64 kB ✓
routerDirect..dc9d.js gzip 303 B 303 B ✓
withRouter-6..0e02.js gzip 302 B 302 B ✓
Overall change 8.64 kB 8.64 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 346 B 346 B ✓
Overall change 346 B 346 B ✓
Serverless bundles
vercel/next.js canary azukaru/next.js new-lint Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.6 kB 10.6 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
buildDuration 14s 15.4s ⚠️ +1.4s
nodeModulesSize 45.5 MB 61.3 MB ⚠️ +15.8 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js new-lint Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.054 2.011 -0.04
/ avg req/sec 1216.85 1242.98 +26.13
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.219 1.25 ⚠️ +0.03
/error-in-render avg req/sec 2050.74 1999.95 ⚠️ -50.79
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js new-lint Change
597-12fee761..569d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 7.11 kB 7.11 kB ✓
webpack-HASH.js gzip 993 B 993 B ✓
Overall change 60.7 kB 60.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js new-lint Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js new-lint Change
_app-b5edc60..e5c2.js gzip 1.29 kB 1.29 kB ✓
_error-b58c1..9b8e.js gzip 3.4 kB 3.4 kB ✓
amp-89a5460c..567f.js gzip 558 B 558 B ✓
hooks-8c2e74..be37.js gzip 924 B 924 B ✓
index-fec729..83b2.js gzip 243 B 243 B ✓
link-3631090..4cab.js gzip 1.65 kB 1.65 kB ✓
routerDirect..20d7.js gzip 328 B 328 B ✓
withRouter-b..a4b9.js gzip 326 B 326 B ✓
Overall change 8.72 kB 8.72 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js new-lint Change
_buildManifest.js gzip 325 B 325 B ✓
Overall change 325 B 325 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js new-lint Change
index.html gzip 585 B 585 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "C44lajWO6TaUNBvSgNrBd",
+        "buildId": "ghW-Baj_bsO386t9dE_rI",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/C44lajWO6TaUNBvSgNrBd/_buildManifest.js"
+      src="/_next/static/ghW-Baj_bsO386t9dE_rI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/C44lajWO6TaUNBvSgNrBd/_ssgManifest.js"
+      src="/_next/static/ghW-Baj_bsO386t9dE_rI/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "C44lajWO6TaUNBvSgNrBd",
+        "buildId": "ghW-Baj_bsO386t9dE_rI",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/C44lajWO6TaUNBvSgNrBd/_buildManifest.js"
+      src="/_next/static/ghW-Baj_bsO386t9dE_rI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/C44lajWO6TaUNBvSgNrBd/_ssgManifest.js"
+      src="/_next/static/ghW-Baj_bsO386t9dE_rI/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "C44lajWO6TaUNBvSgNrBd",
+        "buildId": "ghW-Baj_bsO386t9dE_rI",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/C44lajWO6TaUNBvSgNrBd/_buildManifest.js"
+      src="/_next/static/ghW-Baj_bsO386t9dE_rI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/C44lajWO6TaUNBvSgNrBd/_ssgManifest.js"
+      src="/_next/static/ghW-Baj_bsO386t9dE_rI/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 4be0299
@ijjk
ijjk approved these changes Mar 23, 2021
View changes
@kodiakhq kodiakhq bot merged commit e5ef60f into vercel:canary Mar 23, 2021
28 of 32 checks passed
28 of 32 checks passed
build
Details
Cancel Previous Runs
Details
PR Stats
Details
testYarnPnP
Details
Webpack 5 (Basic, Production, Acceptance)
Details
React 16 + Webpack 4 (Basic, Production, Acceptance)
Details
lint
Details
Check Pre-compiled
Details
Test Unit
Details
Test Integration
Details
Test Integration (1)
Details
Test Integration (2)
Details
Test Integration (3)
Details
Test Integration (4)
Details
Test Integration (5)
Details
Test Integration (6)
Details
Test Electron
Details
Test Firefox (production)
Details
Test Safari (production)
Details
Potentially publish release
Details
thank you, next
Details
Test Safari 10.1 (nav)
Details
Release Stats
Details
azure next.js Build #20210323.11 had test failures
Details
azure next.js (Test test_chrome_integration node-10-1) Test test_chrome_integration node-10-1 failed
Details
azure next.js (Test test_chrome_integration node-10-2) Test test_chrome_integration node-10-2 failed
Details
azure next.js (Test test_chrome_integration node-10-3) Test test_chrome_integration node-10-3 failed
Details
kodiakhq: status ⛴ attempting to merge PR (merging)
Details
azure next.js (Build build) Build build succeeded
Details
azure next.js (Test test_chrome_integration node-10-4) Test test_chrome_integration node-10-4 succeeded
Details
azure next.js (Test test_ie11_production) Test test_ie11_production succeeded
Details
azure next.js (Test test_unit) Test test_unit succeeded
Details
@jacobwgillespie jacobwgillespie mentioned this pull request Mar 29, 2021
Open
Timer added a commit to Timer/next.js that referenced this pull request Mar 29, 2021
@Timer
Revert "Add ESLint to Next.js (vercel#22437)"
Verified
This commit was signed with the committer’s verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
7cc13dd 
This reverts commit e5ef60f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janicklas-ralph janicklas-ralph

@timneutkens timneutkens

@leerob leerob

@ijjk ijjk

@divmain divmain

@lfades lfades

@Timer Timer

@shuding shuding

Assignees
No one assigned
Labels
kind: story type: chrome type: documentation type: example type: next
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@housseindjirdeh @leerob @ijjk @janicklas-ralph @timneutkens