Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI docs change diff check #21558

Merged
merged 4 commits into from Jan 26, 2021
Merged

Update CI docs change diff check #21558

merged 4 commits into from Jan 26, 2021

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Jan 26, 2021

Follow-up to #21530 which updates the diff to not consider un-merged changes on canary to be included in the diff so that branches don't have to be caught up to canary for the diff to detect docs only changes correctly.

@ijjk

This comment has been hidden.

@ijjk ijjk marked this pull request as ready for review Jan 26, 2021
@ijjk ijjk requested review from lfades, Timer and timneutkens as code owners Jan 26, 2021
@ijjk

This comment has been hidden.

@ijjk
Copy link
Member Author

@ijjk ijjk commented Jan 26, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
buildDuration 10.2s 10.3s ⚠️ +118ms
nodeModulesSize 74.9 MB 74.9 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
/ failed reqs 0 0
/ total time (seconds) 2.028 2.013 -0.02
/ avg req/sec 1232.91 1242.2 +9.29
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.228 1.279 ⚠️ +0.05
/error-in-render avg req/sec 2035.92 1954.16 ⚠️ -81.76
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
buildDuration 12.2s 12.3s ⚠️ +84ms
nodeModulesSize 74.9 MB 74.9 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
buildDuration 13s 13.1s ⚠️ +52ms
nodeModulesSize 74.9 MB 74.9 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
/ failed reqs 0 0
/ total time (seconds) 2.122 2.009 -0.11
/ avg req/sec 1178.38 1244.58 +66.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.379 1.287 -0.09
/error-in-render avg req/sec 1812.7 1942.09 +129.39
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
597-c48889ef..1870.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.8 kB 59.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB
hooks-725de8..0a15.js gzip 904 B 904 B
index-939503..6e1c.js gzip 232 B 232 B
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB
routerDirect..9360.js gzip 308 B 308 B
withRouter-6..44ec.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
index.html gzip 587 B 587 B
link.html gzip 591 B 591 B
withRouter.html gzip 580 B 580 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "x15bQzjhnqxOsn-3GupAm",
+        "buildId": "qESep-aPt2zgw4ht9WpQF",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/x15bQzjhnqxOsn-3GupAm/_buildManifest.js"
+      src="/_next/static/qESep-aPt2zgw4ht9WpQF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/x15bQzjhnqxOsn-3GupAm/_ssgManifest.js"
+      src="/_next/static/qESep-aPt2zgw4ht9WpQF/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "x15bQzjhnqxOsn-3GupAm",
+        "buildId": "qESep-aPt2zgw4ht9WpQF",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/x15bQzjhnqxOsn-3GupAm/_buildManifest.js"
+      src="/_next/static/qESep-aPt2zgw4ht9WpQF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/x15bQzjhnqxOsn-3GupAm/_ssgManifest.js"
+      src="/_next/static/qESep-aPt2zgw4ht9WpQF/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "x15bQzjhnqxOsn-3GupAm",
+        "buildId": "qESep-aPt2zgw4ht9WpQF",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/x15bQzjhnqxOsn-3GupAm/_buildManifest.js"
+      src="/_next/static/qESep-aPt2zgw4ht9WpQF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/x15bQzjhnqxOsn-3GupAm/_ssgManifest.js"
+      src="/_next/static/qESep-aPt2zgw4ht9WpQF/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 875c92c
@Timer
Timer approved these changes Jan 26, 2021
@ijjk
Copy link
Member Author

@ijjk ijjk commented Jan 26, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
buildDuration 10.6s 10.4s -186ms
nodeModulesSize 74.9 MB 74.9 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
/ failed reqs 0 0
/ total time (seconds) 2.058 2.051 -0.01
/ avg req/sec 1214.74 1218.95 +4.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.28 1.289 ⚠️ +0.01
/error-in-render avg req/sec 1953.86 1939.15 ⚠️ -14.71
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
buildDuration 12.7s 12.5s -115ms
nodeModulesSize 74.9 MB 74.9 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
buildDuration 12.7s 12.9s ⚠️ +130ms
nodeModulesSize 74.9 MB 74.9 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
/ failed reqs 0 0
/ total time (seconds) 2.043 2.098 ⚠️ +0.05
/ avg req/sec 1223.88 1191.74 ⚠️ -32.14
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.303 1.346 ⚠️ +0.04
/error-in-render avg req/sec 1919.29 1857.99 ⚠️ -61.3
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
597-c48889ef..1870.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.8 kB 59.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB
hooks-725de8..0a15.js gzip 904 B 904 B
index-939503..6e1c.js gzip 232 B 232 B
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB
routerDirect..9360.js gzip 308 B 308 B
withRouter-6..44ec.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js ci/update-diff-check Change
index.html gzip 587 B 587 B
link.html gzip 591 B 591 B
withRouter.html gzip 580 B 580 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "znZRqCmODCDU3A5NxARTH",
+        "buildId": "NYNJ_rozF_7MZ-iw8pw1k",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/znZRqCmODCDU3A5NxARTH/_buildManifest.js"
+      src="/_next/static/NYNJ_rozF_7MZ-iw8pw1k/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/znZRqCmODCDU3A5NxARTH/_ssgManifest.js"
+      src="/_next/static/NYNJ_rozF_7MZ-iw8pw1k/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "znZRqCmODCDU3A5NxARTH",
+        "buildId": "NYNJ_rozF_7MZ-iw8pw1k",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/znZRqCmODCDU3A5NxARTH/_buildManifest.js"
+      src="/_next/static/NYNJ_rozF_7MZ-iw8pw1k/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/znZRqCmODCDU3A5NxARTH/_ssgManifest.js"
+      src="/_next/static/NYNJ_rozF_7MZ-iw8pw1k/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "znZRqCmODCDU3A5NxARTH",
+        "buildId": "NYNJ_rozF_7MZ-iw8pw1k",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/znZRqCmODCDU3A5NxARTH/_buildManifest.js"
+      src="/_next/static/NYNJ_rozF_7MZ-iw8pw1k/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/znZRqCmODCDU3A5NxARTH/_ssgManifest.js"
+      src="/_next/static/NYNJ_rozF_7MZ-iw8pw1k/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: f7afd42
@ijjk ijjk merged commit cca2000 into vercel:canary Jan 26, 2021
28 of 30 checks passed
28 of 30 checks passed
build
Details
PR Stats
Details
testYarnPnP
Details
Webpack 5 (Basic, Production, Acceptance)
Details
React 16 + Webpack 4 (Basic, Production, Acceptance)
Details
lint
Details
Check Pre-compiled
Details
Test Unit
Details
Test Integration (1)
Details
Test Integration (2)
Details
Test Integration (3)
Details
Test Integration (4)
Details
Test Integration (5)
Details
Test Integration (6)
Details
Test Electron
Details
Test Firefox (production)
Details
Test Safari (production)
Details
thank you, next
Details
Test Safari 10.1 (nav)
Details
Potentially publish release
Details
Release Stats
Details
azure next.js Build #20210126.32 had test failures
Details
azure next.js (Test test_chrome_integration node-10-1) Test test_chrome_integration node-10-1 failed
Details
kodiakhq: status ⛴ attempting to merge PR (merging)
Details
azure next.js (Build build) Build build succeeded
Details
azure next.js (Test test_chrome_integration node-10-2) Test test_chrome_integration node-10-2 succeeded
Details
azure next.js (Test test_chrome_integration node-10-3) Test test_chrome_integration node-10-3 succeeded
Details
azure next.js (Test test_chrome_integration node-10-4) Test test_chrome_integration node-10-4 succeeded
Details
azure next.js (Test test_ie11_production) Test test_ie11_production succeeded
Details
azure next.js (Test test_unit) Test test_unit succeeded
Details
@ijjk ijjk deleted the ijjk:ci/update-diff-check branch Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants