Skip to content

/ next.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence GH Comments for Preview URLs #18766

Merged
merged 1 commit into from Nov 3, 2020
Merged

Silence GH Comments for Preview URLs #18766

merged 1 commit into from Nov 3, 2020

Conversation

@styfle
Copy link
Member

@styfle styfle commented Nov 3, 2020 •
edited

Disabling GH Comments per @Timer

These are the same settings we use for the vercel/vercel repo.
@styfle
Silence GH Comments for Preview URLs
Loading status checks…
3881a38
@styfle styfle requested review from ijjk, lfades, Timer and timneutkens as code owners Nov 3, 2020
@ijjk
Copy link
Member

@ijjk ijjk commented Nov 3, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js vercel-gh-disable Change
buildDuration 11.4s 11.5s ⚠️ +64ms
nodeModulesSize 90 MB 90 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js vercel-gh-disable Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.172 2.175 0
/ avg req/sec 1151.2 1149.41 ⚠️ -1.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.193 1.194 0
/error-in-render avg req/sec 2095.81 2094.17 ⚠️ -1.64
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js vercel-gh-disable Change
677f882d2ed8..1f3c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-be398bc..d262.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary vercel/next.js vercel-gh-disable Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-378f0c6..dule.js gzip 6.33 kB 6.33 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js vercel-gh-disable Change
polyfills-b5..1119.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js vercel-gh-disable Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary vercel/next.js vercel-gh-disable Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js vercel-gh-disable Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js vercel-gh-disable Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary vercel/next.js vercel-gh-disable Change
buildDuration 12.8s 13s ⚠️ +132ms
nodeModulesSize 90 MB 90 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js vercel-gh-disable Change
677f882d2ed8..1f3c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-be398bc..d262.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary vercel/next.js vercel-gh-disable Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-378f0c6..dule.js gzip 6.33 kB 6.33 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js vercel-gh-disable Change
polyfills-b5..1119.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js vercel-gh-disable Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary vercel/next.js vercel-gh-disable Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js vercel-gh-disable Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary vercel/next.js vercel-gh-disable Change
_error.js 1.07 MB 1.07 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.07 MB 1.07 MB ✓
link.js 1.12 MB 1.12 MB ✓
routerDirect.js 1.11 MB 1.11 MB ✓
withRouter.js 1.11 MB 1.11 MB ✓
Overall change 5.48 MB 5.48 MB ✓
Commit: 3881a38
@lfades
lfades approved these changes Nov 3, 2020
View changes
@kodiakhq kodiakhq bot merged commit 7e51b29 into canary Nov 3, 2020
19 of 26 checks passed
19 of 26 checks passed
build
Details
PR Stats
Details
testYarnPnP
Details
React 17 + webpack 5 (Basic, Production, Acceptance) React 17 + webpack 5 (Basic, Production, Acceptance)
Details
lint
Details
Check Pre-compiled
Details
Test All (1)
Details
Test All (2)
Details
Test All (3)
Details
Test All (4)
Details
Test All (5)
Details
Test All (6)
Details
Test Firefox (production)
Details
Test Safari (production)
Details
thank you, next
Details
Test Safari 10.1 (nav)
Details
Potentially publish release
Details
Release Stats
Details
azure next.js (test_chrome node-10-1) test_chrome node-10-1 failed
Details
azure next.js (test_chrome node-10-2) test_chrome node-10-2 failed
Details
azure next.js (test_chrome node-10-3) test_chrome node-10-3 failed
Details
azure next.js (test_chrome node-10-4) test_chrome node-10-4 failed
Details
azure next.js (test_ie11) test_ie11 failed
Details
azure next.js
Details
kodiakhq: status ⛴ attempting to merge PR (merging)
Details
Vercel Canceled by Ignored Build Step
Details
@kodiakhq kodiakhq bot deleted the vercel-gh-disable branch Nov 3, 2020
jamesgeorge007 added a commit to jamesgeorge007/next.js that referenced this pull request Nov 5, 2020
@styfle @jamesgeorge007
Silence GH Comments for Preview URLs (vercel#18766)
ff7d30e 
Disabling GH Comments per @Timer 

These are the same settings we use for the `vercel/vercel` repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfades lfades

@ijjk ijjk

@Timer Timer

@timneutkens timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@styfle @ijjk @lfades