Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable #13716

Merged
merged 7 commits into from Jun 3, 2020
Merged

Conversation

@timneutkens
Copy link
Member

@timneutkens timneutkens commented Jun 3, 2020

Noticed this variable was not used.

@timneutkens timneutkens requested review from ijjk, lfades and Timer as code owners Jun 3, 2020
@ijjk
Copy link
Member

@ijjk ijjk commented Jun 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
buildDuration 14.4s 14.6s ⚠️ +182ms
nodeModulesSize 66 MB 66 MB -158 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
/ failed reqs 0 0
/ total time (seconds) 2.541 2.481 -0.06
/ avg req/sec 983.96 1007.61 ⚠️ +23.65
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.711 1.593 -0.12
/error-in-render avg req/sec 1461.12 1569.15 ⚠️ +108.03
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
index.html gzip 924 B 924 B
link.html gzip 934 B 934 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
buildDuration 14.9s 15s ⚠️ +47ms
nodeModulesSize 66 MB 66 MB -158 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_error.js 878 kB 878 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 879 kB 879 kB
link.js 916 kB 916 kB
routerDirect.js 909 kB 909 kB
withRouter.js 909 kB 909 kB
Overall change 4.5 MB 4.5 MB
@timneutkens timneutkens dismissed stale reviews from ijjk and Timer via 6a5b005 Jun 3, 2020
@Timer Timer added this to the 9.4.5 milestone Jun 3, 2020
@ijjk
Copy link
Member

@ijjk ijjk commented Jun 3, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
buildDuration 15.2s 14.8s -424ms
nodeModulesSize 66 MB 66 MB -260 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
/ failed reqs 0 0
/ total time (seconds) 2.825 2.684 -0.14
/ avg req/sec 884.99 931.39 ⚠️ +46.4
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.882 2.116 ⚠️ +0.23
/error-in-render avg req/sec 1328.49 1181.34 -147.15
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
index.html gzip 924 B 924 B
link.html gzip 934 B 934 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
buildDuration 16s 16.8s ⚠️ +811ms
nodeModulesSize 66 MB 66 MB -260 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_error.js 878 kB 878 kB
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 879 kB 879 kB
link.js 916 kB 916 kB
routerDirect.js 909 kB 909 kB
withRouter.js 909 kB 909 kB
Overall change 4.5 MB 4.5 MB
@Timer Timer dismissed their stale review via 8f03a98 Jun 3, 2020
@Timer
Timer approved these changes Jun 3, 2020
@ijjk
Copy link
Member

@ijjk ijjk commented Jun 3, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
buildDuration 11.6s 11.7s ⚠️ +66ms
nodeModulesSize 66 MB 66 MB -401 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
/ failed reqs 0 0
/ total time (seconds) 1.965 1.966 0
/ avg req/sec 1272.36 1271.54 -0.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.19 1.222 ⚠️ +0.03
/error-in-render avg req/sec 2100.62 2045.73 -54.89
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
index.html gzip 924 B 924 B
link.html gzip 934 B 934 B
withRouter.html gzip 922 B 922 B
Overall change 2.78 kB 2.78 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
buildDuration 13.3s 15s ⚠️ +1.7s
nodeModulesSize 66 MB 66 MB -401 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.js gzip 6.59 kB 6.59 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..6c2a.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 57 kB 57 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
main-HASH.module.js gzip 5.67 kB 5.67 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.93 kB 6.93 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 52.5 kB 52.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.js gzip 1.26 kB 1.26 kB
_error.js gzip 3.25 kB 3.25 kB
hooks.js gzip 881 B 881 B
index.js gzip 222 B 222 B
link.js gzip 2.05 kB 2.05 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 8.21 kB 8.21 kB
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_app.module.js gzip 604 B 604 B
_error.module.js gzip 2.04 kB 2.04 kB
hooks.module.js gzip 383 B 383 B
index.module.js gzip 223 B 223 B
link.module.js gzip 1.51 kB 1.51 kB
routerDirect..dule.js gzip 281 B 281 B
withRouter.m..dule.js gzip 278 B 278 B
Overall change 5.32 kB 5.32 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-unused-variable-entries Change
_error.js 878 kB 878 kB -52 B
404.html 4.18 kB 4.18 kB
hooks.html 3.81 kB 3.81 kB
index.js 879 kB 879 kB -52 B
link.js 916 kB 916 kB -52 B
routerDirect.js 909 kB 909 kB -52 B
withRouter.js 909 kB 909 kB -52 B
Overall change 4.5 MB 4.5 MB -260 B
@Timer Timer merged commit 0fc344e into vercel:canary Jun 3, 2020
19 of 22 checks passed
19 of 22 checks passed
build
Details
PR Stats
Details
lint
Details
Check Pre-compiled
Details
Test All (1)
Details
Test All (2)
Details
Test All (3)
Details
Test All (4)
Details
Test All (5)
Details
Test All (6)
Details
Test Firefox (production)
Details
Test Safari (production)
Details
thank you, next
Details
Test Safari 10.1 (nav)
Details
Potentially publish release
Details
azure next.js Build #20200603.34 failed
Details
azure next.js (test_chrome node-10-1) test_chrome node-10-1 was canceled
Details
azure next.js (test_chrome node-10-2) test_chrome node-10-2 was canceled
Details
kodiakhq: status ⛴ merging PR (waiting for status checks: {'Test All (6)', 'Test All (4)', 'PR Stats', 'Test All (2)'})
Details
azure next.js (test_chrome node-10-3) test_chrome node-10-3 succeeded
Details
azure next.js (test_chrome node-10-4) test_chrome node-10-4 succeeded
Details
azure next.js (test_ie11) test_ie11 succeeded
Details
rokinsky added a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
Co-authored-by: Joe Haddad <joe.haddad@zeit.co>
@timneutkens timneutkens deleted the timneutkens:fix/remove-unused-variable-entries branch Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants