Update browserslist/caniuse-lite #13605
Merged
Conversation
kodiakhq
bot
merged commit f697574
into
vercel:canary
19 of 21 checks passed
19 of 21 checks passed
rokinsky
added a commit
to rokinsky/next.js
that referenced
this pull request
Jul 11, 2020
Looks like `caniuse-lite` is out of date and causing test failures. - I upgraded both `browserslist` and `caniuse-lite` to latest semver compatible version. - This seemed to cause changes in ncc compiled files, so recompiled. - `lint-staged` failed on these files even though they should be ignored. As a fix, I applied the advice from https://github.com/okonet/lint-staged#how-can-i-ignore-files-from-eslintignore- - Updated some test snapshots.🤔 not sure this is the way to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Looks like
caniuse-liteis out of date and causing test failures.browserslistandcaniuse-liteto latest semver compatible version.lint-stagedfailed on these files even though they should be ignored. As a fix, I applied the advice from https://github.com/okonet/lint-staged#how-can-i-ignore-files-from-eslintignore-