Skip to content

/ next.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional file serving tests #12479

Merged
merged 8 commits into from May 4, 2020
Merged

Add additional file serving tests #12479

merged 8 commits into from May 4, 2020
+4,502 −3

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented May 4, 2020

This adds some additional tests for file serving it also fixes a bug in dev mode where hasPage would throw an error on an invalid page name instead of returning false
Timer and others added 6 commits Mar 26, 2020
@Timer
Test `static/` file name encoding
Verified
This commit was signed with the committer’s verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
157ddb6
@Timer
Fix `static/` file name encoding
Verified
This commit was signed with the committer’s verified signature.
Timer Joe Haddad
GPG key ID: C5B785A7D0DE1654 Learn about signing commits
Loading status checks…
223a98a
@ijjk
Add additional file-serving tests
Unverified
This user has not uploaded their public key yet.
GPG key ID: 6CFC4C3DAD69C3E4 Learn about signing commits
2aa4ad5
@ijjk
Merge remote-tracking branch 'upstream/canary' into add/traversal-tests
Unverified
This user has not uploaded their public key yet.
GPG key ID: 6CFC4C3DAD69C3E4 Learn about signing commits
9caf3ff
@ijjk
Merge remote-tracking branch 'upstream/canary' into add/traversal-tests
Unverified
This user has not uploaded their public key yet.
GPG key ID: 6CFC4C3DAD69C3E4 Learn about signing commits
063b0f6
@ijjk
Merge remote-tracking branch 'upstream/canary' into add/traversal-tests
Unverified
This user has not uploaded their public key yet.
GPG key ID: 6CFC4C3DAD69C3E4 Learn about signing commits
Loading status checks…
4a418e8
@ijjk ijjk added this to the 9.3.7 milestone May 4, 2020
@ijjk ijjk requested review from lfades, Timer and timneutkens as code owners May 4, 2020
@ijjk
Copy link
Member Author

@ijjk ijjk commented May 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js test/file-serving Change
buildDuration 13.8s 13.9s ⚠️ +74ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +252 B
Page Load Tests Overall increase ✓
zeit/next.js canary ijjk/next.js test/file-serving Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.4 2.361 -0.04
/ avg req/sec 1041.86 1058.65 ⚠️ +16.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.532 1.495 -0.04
/error-in-render avg req/sec 1631.73 1672.16 ⚠️ +40.43
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js test/file-serving Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js test/file-serving Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js test/file-serving Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js test/file-serving Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js test/file-serving Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js test/file-serving Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js test/file-serving Change
index.html gzip 925 B 925 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js test/file-serving Change
buildDuration 14.8s 15.1s ⚠️ +297ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +252 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js test/file-serving Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js test/file-serving Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js test/file-serving Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js test/file-serving Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js test/file-serving Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js test/file-serving Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js test/file-serving Change
_error.js 853 kB 853 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 853 kB 853 kB ✓
link.js 891 kB 891 kB ✓
routerDirect.js 883 kB 883 kB ✓
withRouter.js 883 kB 883 kB ✓
Overall change 4.37 MB 4.37 MB ✓
ijjk added 2 commits May 4, 2020
@ijjk
Merge branch 'canary' into test/file-serving
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dadb1df
@ijjk
bump
Unverified
This user has not uploaded their public key yet.
GPG key ID: 6CFC4C3DAD69C3E4 Learn about signing commits
Loading status checks…
8d955f4
@ijjk
Copy link
Member Author

@ijjk ijjk commented May 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js test/file-serving Change
buildDuration 10.5s 10.7s ⚠️ +133ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +252 B
Page Load Tests Overall increase ✓
zeit/next.js canary ijjk/next.js test/file-serving Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.987 1.841 -0.15
/ avg req/sec 1258.1 1358.32 ⚠️ +100.22
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.25 1.224 -0.03
/error-in-render avg req/sec 1999.37 2042.44 ⚠️ +43.07
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js test/file-serving Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js test/file-serving Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js test/file-serving Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js test/file-serving Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js test/file-serving Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js test/file-serving Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js test/file-serving Change
index.html gzip 925 B 925 B ✓
link.html gzip 935 B 935 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary ijjk/next.js test/file-serving Change
buildDuration 11.3s 11.2s -143ms
nodeModulesSize 57.5 MB 57.5 MB ⚠️ +252 B
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js test/file-serving Change
main-HASH.js gzip 6.28 kB 6.28 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5232.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js test/file-serving Change
main-HASH.module.js gzip 4.82 kB 4.82 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js test/file-serving Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js test/file-serving Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.13 kB 3.13 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js test/file-serving Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js test/file-serving Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js test/file-serving Change
_error.js 853 kB 853 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 853 kB 853 kB ✓
link.js 891 kB 891 kB ✓
routerDirect.js 883 kB 883 kB ✓
withRouter.js 883 kB 883 kB ✓
Overall change 4.37 MB 4.37 MB ✓
@Timer
Timer approved these changes May 4, 2020
View changes
Copy link
Member

@Timer Timer left a comment

Awesome!
@ijjk ijjk merged commit 00d930a into vercel:canary May 4, 2020
19 of 21 checks passed
19 of 21 checks passed
build
Details
PR Stats
Details
lint
Details
Check Pre-compiled
Details
Test All (1)
Details
Test All (2)
Details
Test All (3)
Details
Test All (4)
Details
Test All (5)
Details
Test All (6)
Details
Test Firefox (production)
Details
Test Safari (production)
Details
thank you, next
Details
Test Safari 10.1 (nav)
Details
Potentially publish release
Details
azure next.js Build #20200504.22 had test failures
Details
azure next.js (test_chrome node-10-4) test_chrome node-10-4 failed
Details
azure next.js (test_chrome node-10-1) test_chrome node-10-1 succeeded
Details
azure next.js (test_chrome node-10-2) test_chrome node-10-2 succeeded
Details
azure next.js (test_chrome node-10-3) test_chrome node-10-3 succeeded
Details
azure next.js (test_ie11) test_ie11 succeeded
Details
@ijjk ijjk deleted the ijjk:test/file-serving branch May 4, 2020
@Timer Timer modified the milestones: 9.3.7, 9.4 May 11, 2020
rokinsky added a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@ijjk @Timer @rokinsky
Add additional file serving tests (vercel#12479)
8587b4d 
* Test `static/` file name encoding

* Fix `static/` file name encoding

* Add additional file-serving tests

* bump

Co-authored-by: Joe Haddad <joe.haddad@zeit.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timer Timer

@lfades lfades

@timneutkens timneutkens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ijjk @Timer