Skip to content

/ next.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move upgrading guide to /docs #10727

Merged
merged 7 commits into from Feb 28, 2020
Merged

Move upgrading guide to /docs #10727

merged 7 commits into from Feb 28, 2020

Conversation

@chibicode
Copy link
Member

@chibicode chibicode commented Feb 28, 2020 •
edited

As @timneutkens suggested, this PR moves UPGRADING.md to docs so it'll be on the documentation site. I modified the title to say version 9.0.x instead of version 9 because versions >= 9.1.x have more changes than outlined here. This allows us to add more upgrading guides in the future.
chibicode added 2 commits Feb 28, 2020
@chibicode
Move UPGRADING.md to docs
99d593e
@chibicode
Add upgrading guide to manifest.json
Loading status checks…
5954939
@chibicode chibicode requested a review from Timer as a code owner Feb 28, 2020
@chibicode chibicode requested a review from timneutkens Feb 28, 2020
@chibicode
Update title
Loading status checks…
f6d3013
@ijjk
Copy link
Member

@ijjk ijjk commented Feb 28, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary chibicode/next.js move-upgrading Change
buildDuration 9.6s 9.7s ⚠️ +190ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary chibicode/next.js move-upgrading Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.4 kB 7.4 kB ✓
Client Pages Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary chibicode/next.js move-upgrading Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary chibicode/next.js move-upgrading Change
index.html gzip 923 B 923 B ✓
link.html gzip 932 B 932 B ✓
withRouter.html gzip 921 B 921 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary chibicode/next.js move-upgrading Change
buildDuration 10.5s 10.4s -96ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary chibicode/next.js move-upgrading Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.4 kB 7.4 kB ✓
Client Pages Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary chibicode/next.js move-upgrading Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary chibicode/next.js move-upgrading Change
_error.js gzip 292 kB 292 kB -145 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 964 B 964 B ✓
index.js gzip 293 kB 292 kB -669 B
link.js gzip 300 kB 300 kB ⚠️ +222 B
routerDirect.js gzip 298 kB 298 kB -120 B
withRouter.js gzip 298 kB 298 kB ⚠️ +405 B
Overall change 1.48 MB 1.48 MB -307 B

Commit: 5954939
@ijjk
Copy link
Member

@ijjk ijjk commented Feb 28, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary chibicode/next.js move-upgrading Change
buildDuration 10s 10.1s ⚠️ +43ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary chibicode/next.js move-upgrading Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.4 kB 7.4 kB ✓
Client Pages Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary chibicode/next.js move-upgrading Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary chibicode/next.js move-upgrading Change
index.html gzip 923 B 923 B ✓
link.html gzip 932 B 932 B ✓
withRouter.html gzip 921 B 921 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary chibicode/next.js move-upgrading Change
buildDuration 10.6s 10.8s ⚠️ +268ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..49f4.js gzip 12.3 kB 12.3 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 9.22 kB 9.22 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 53.2 kB 53.2 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary chibicode/next.js move-upgrading Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.4 kB 7.4 kB ✓
Client Pages Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary chibicode/next.js move-upgrading Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary chibicode/next.js move-upgrading Change
_error.js gzip 292 kB 292 kB -450 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 964 B 964 B ✓
index.js gzip 293 kB 292 kB -1.14 kB
link.js gzip 300 kB 300 kB ⚠️ +21 B
routerDirect.js gzip 298 kB 298 kB -256 B
withRouter.js gzip 298 kB 299 kB ⚠️ +1.09 kB
Overall change 1.48 MB 1.48 MB -734 B

Commit: f6d3013
@timneutkens
timneutkens reviewed Feb 28, 2020
View changes
UPGRADING.md Show resolved Hide resolved
@chibicode
Move to docs/upgrading
Loading status checks…
1ac4bbc
@ijjk
Copy link
Member

@ijjk ijjk commented Feb 28, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary chibicode/next.js move-upgrading Change
buildDuration 9.6s 10s ⚠️ +443ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 54.6 kB 54.6 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 50.6 kB 50.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary chibicode/next.js move-upgrading Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary chibicode/next.js move-upgrading Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary chibicode/next.js move-upgrading Change
index.html gzip 923 B 923 B ✓
link.html gzip 931 B 931 B ✓
withRouter.html gzip 922 B 922 B ✓
Overall change 2.78 kB 2.78 kB ✓
Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary chibicode/next.js move-upgrading Change
buildDuration 10.7s 10.5s -174ms
nodeModulesSize 56.3 MB 56.3 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.js gzip 4.98 kB 4.98 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..7030.js gzip 9.68 kB 9.68 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 54.6 kB 54.6 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.63 kB 6.63 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 50.6 kB 50.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary chibicode/next.js move-upgrading Change
polyfills-HASH.js gzip 18.9 kB 18.9 kB ✓
Overall change 18.9 kB 18.9 kB ✓
Client Pages
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.js gzip 1.07 kB 1.07 kB ✓
_error.js gzip 2.98 kB 2.98 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 1.9 kB 1.9 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.39 kB 7.39 kB ✓
Client Pages Modern
zeit/next.js canary chibicode/next.js move-upgrading Change
_app.module.js gzip 589 B 589 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.27 kB 5.27 kB ✓
Client Build Manifests
zeit/next.js canary chibicode/next.js move-upgrading Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary chibicode/next.js move-upgrading Change
_error.js gzip 292 kB 293 kB ⚠️ +238 B
404.html gzip 1.33 kB 1.33 kB ✓
hooks.html gzip 963 B 963 B ✓
index.js gzip 293 kB 293 kB -316 B
link.js gzip 299 kB 300 kB ⚠️ +764 B
routerDirect.js gzip 299 kB 298 kB -1.26 kB
withRouter.js gzip 299 kB 299 kB ⚠️ +107 B
Overall change 1.48 MB 1.48 MB -471 B

Commit: 1ac4bbc
@timneutkens
timneutkens reviewed Feb 28, 2020
View changes
UPGRADING.md Outdated Show resolved Hide resolved
@timneutkens
Update UPGRADING.md
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3780bb2
@timneutkens
timneutkens reviewed Feb 28, 2020
View changes
docs/manifest.json Outdated Show resolved Hide resolved
@timneutkens
Update docs/manifest.json
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ca6b1d4
@timneutkens
timneutkens reviewed Feb 28, 2020
View changes
UPGRADING.md Outdated Show resolved Hide resolved
@timneutkens
Update UPGRADING.md
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1f90f0b
@timneutkens
timneutkens approved these changes Feb 28, 2020
View changes
@timneutkens timneutkens merged commit 709aac1 into vercel:canary Feb 28, 2020
8 checks passed
8 checks passed
build
Details
PR Stats
Details
azure next.js Build #20200228.41 had test failures
Details
azure next.js (test_chrome node-10-1) test_chrome node-10-1 succeeded
Details
azure next.js (test_chrome node-10-2) test_chrome node-10-2 succeeded
Details
azure next.js (test_chrome node-10-3) test_chrome node-10-3 succeeded
Details
azure next.js (test_chrome node-10-4) test_chrome node-10-4 succeeded
Details
azure next.js (test_ie11) test_ie11 succeeded
Details
@Johbrun Johbrun mentioned this pull request Apr 6, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timneutkens timneutkens

@Timer Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@chibicode @ijjk @timneutkens