Skip to content

/ next.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to exit publish script with correct code #10310

Merged
merged 1 commit into from Jan 28, 2020
Merged

Make sure to exit publish script with correct code #10310

merged 1 commit into from Jan 28, 2020

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Jan 28, 2020

If the publish fails the publish job should be marked as failed instead of passing this makes sure we honor the exit code from yarn for the publish-release script
@ijjk
Make sure to exit publish script with correct code
Unverified
This user has not uploaded their public key yet.
GPG key ID: 6CFC4C3DAD69C3E4 Learn about signing commits
Loading status checks…
caa47db
@ijjk ijjk added this to the 9.2.2 milestone Jan 28, 2020
@ijjk ijjk requested a review from Timer as a code owner Jan 28, 2020
@ijjk
Copy link
Member Author

@ijjk ijjk commented Jan 28, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary ijjk/next.js update/publish-script Change
buildDuration 11.4s 11.4s ⚠️� +15ms
nodeModulesSize 52.1 MB 52.1 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js update/publish-script Change
main-HASH.js gzip 5.1 kB 5.1 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..d6ae.js gzip 16.2 kB 16.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 69.9 kB 69.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js update/publish-script Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.6 kB 64.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js update/publish-script Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js update/publish-script Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js update/publish-script Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js update/publish-script Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js update/publish-script Change
index.html gzip 1.02 kB 1.02 kB ✓
link.html gzip 1.03 kB 1.03 kB ✓
withRouter.html gzip 1.02 kB 1.02 kB ✓
Overall change 3.07 kB 3.07 kB ✓
Serverless Mode
General
zeit/next.js canary ijjk/next.js update/publish-script Change
buildDuration 11.7s 11.3s -378ms
nodeModulesSize 52.1 MB 52.1 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js update/publish-script Change
main-HASH.js gzip 5.1 kB 5.1 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
4952ddcd88e7..54d3.js gzip 4.68 kB 4.68 kB ✓
commons.HASH.js gzip 4.06 kB 4.06 kB ✓
de003c3a9d30..d6ae.js gzip 16.2 kB 16.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 69.9 kB 69.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js update/publish-script Change
main-HASH.module.js gzip 4.1 kB 4.1 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
4952ddcd88e7..dule.js gzip 5.56 kB 5.56 kB ✓
de003c3a9d30..dule.js gzip 15.1 kB 15.1 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 64.6 kB 64.6 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js update/publish-script Change
polyfills-HASH.js gzip 4.76 kB 4.76 kB ✓
Overall change 4.76 kB 4.76 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js update/publish-script Change
_app.js gzip 1.15 kB 1.15 kB ✓
_error.js gzip 4.07 kB 4.07 kB ✓
hooks.js gzip 779 B 779 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.89 kB 2.89 kB ✓
routerDirect.js gzip 283 B 283 B ✓
withRouter.js gzip 282 B 282 B ✓
Overall change 9.68 kB 9.68 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js update/publish-script Change
_app.module.js gzip 576 B 576 B ✓
_error.module.js gzip 3.06 kB 3.06 kB ✓
hooks.module.js gzip 371 B 371 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 2.46 kB 2.46 kB ✓
routerDirect..dule.js gzip 273 B 273 B ✓
withRouter.m..dule.js gzip 272 B 272 B ✓
Overall change 7.22 kB 7.22 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js update/publish-script Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js update/publish-script Change
_error.js gzip 46.6 kB 46.6 kB ✓
hooks.html gzip 1.06 kB 1.06 kB ✓
index.js gzip 46.8 kB 46.8 kB ✓
link.js gzip 72.4 kB 72.4 kB ✓
routerDirect.js gzip 70.4 kB 70.4 kB ✓
withRouter.js gzip 70.5 kB 70.5 kB ✓
Overall change 308 kB 308 kB ✓
@Timer
Timer approved these changes Jan 28, 2020
View changes
@Timer Timer added the ready to land label Jan 28, 2020
@Timer Timer merged commit 6a88ec1 into vercel:canary Jan 28, 2020
19 checks passed
19 checks passed
build
Details
PR Stats
Details
lint
Details
Test All (1)
Details
Test All (2)
Details
Test All (3)
Details
Test All (4)
Details
Test All (5)
Details
Test All (6)
Details
Test Firefox (production)
Details
Test Safari (production)
Details
thank you, next
Details
Potentially publish release
Details
azure next.js Build #20200128.28 had test failures
Details
azure next.js (test_chrome node-10-1) test_chrome node-10-1 succeeded
Details
azure next.js (test_chrome node-10-2) test_chrome node-10-2 succeeded
Details
azure next.js (test_chrome node-10-3) test_chrome node-10-3 succeeded
Details
azure next.js (test_chrome node-10-4) test_chrome node-10-4 succeeded
Details
azure next.js (test_ie11) test_ie11 succeeded
Details
@Timer Timer deleted the ijjk:update/publish-script branch Jan 28, 2020
This was referenced Mar 13, 2020
Closed
Open
This was referenced Mar 22, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timer Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.2.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ijjk @Timer